Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker: add tagging api support for additional services #8056

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

jamarcelin
Copy link
Contributor

@jamarcelin jamarcelin commented Aug 29, 2024

Added ResourceGroupsTaggingAPI support for Sagemaker services:

  • Models
  • Notebook Instances
  • Endpoing Configs, Endpoints
  • Experiments
  • Pipelines
  • Pipeline Executions
  • Processing Jobs
  • Trials
  • Trial Components
  • Training Jobs
  • Transform Jobs
  • Notebook Instance Lifecycle Configurations
  • Model Cards
  • Model Package Groups
  • Model Packages
  • Feature Groups

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moto/sagemaker/models.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.44%. Comparing base (191ebcc) to head (f09ec4f).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
moto/sagemaker/models.py 93.93% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8056      +/-   ##
==========================================
+ Coverage   94.43%   94.44%   +0.01%     
==========================================
  Files        1139     1141       +2     
  Lines       97355    98090     +735     
==========================================
+ Hits        91935    92639     +704     
- Misses       5420     5451      +31     
Flag Coverage Δ
servertests 28.98% <1.38%> (+0.06%) ⬆️
unittests 94.41% <94.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamarcelin
Copy link
Contributor Author

Hey @bblommers, the services have all been updated to only use self.arn. Thanks!

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thank you @jamarcelin!

@bblommers bblommers added this to the 5.0.14 milestone Sep 4, 2024
@bblommers bblommers changed the title added sagemaker tagging api support SageMaker: add tagging api support for additional services Sep 4, 2024
@bblommers bblommers merged commit b4e8c34 into getmoto:master Sep 4, 2024
50 checks passed
Copy link
Contributor

github-actions bot commented Sep 4, 2024

This is now part of moto >= 5.0.14.dev58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants