-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SageMaker: add tagging api support for additional services #8056
SageMaker: add tagging api support for additional services #8056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jamarcelin! It looks like a test is now failing as well: https://github.com/getmoto/moto/actions/runs/10622064984/job/29445807888?pr=8056
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8056 +/- ##
==========================================
+ Coverage 94.43% 94.44% +0.01%
==========================================
Files 1139 1141 +2
Lines 97355 98090 +735
==========================================
+ Hits 91935 92639 +704
- Misses 5420 5451 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @bblommers, the services have all been updated to only use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thank you @jamarcelin!
This is now part of moto >= 5.0.14.dev58 |
Added ResourceGroupsTaggingAPI support for Sagemaker services: