Appmesh virtual node #8050
Appmesh virtual node #8050
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8050 +/- ##
========================================
Coverage 94.43% 94.44%
========================================
Files 1139 1141 +2
Lines 97321 98071 +750
========================================
+ Hits 91903 92620 +717
- Misses 5418 5451 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bblommers ready for review |
|
|
||
| - [ ] create_evaluation_job | ||
| - [ ] create_guardrail | ||
| - [ ] create_guardrail_version | ||
| - [ ] create_model_copy_job |
There was a problem hiding this comment.
Usually when the implementation-script suddenly removes methods like this, it's because the installed botocore module is outdated, and the feature didn't exist yet in the older botocore module.
We'll always update the docs before an actual release, so it's not a big deal if these methods disappear inbetween, just as an FYI; if you update botocore/boto3 before running the implementation-script, this shouldn't happen.
|
|
||
|
|
||
| def clean_dict(obj: Dict[str, Any]) -> Dict[str, Any]: # type: ignore[misc] | ||
| return { |
There was a problem hiding this comment.
This method isnt' used anywhere - looks like the duplicate method in utils.py is used instead.
There was a problem hiding this comment.
LGTM - thank you continuing to improve this area in Moto @armichaud!
The two comments that I've left are not blockers, so I'll just go ahead and merge it as is - feel free to address them in a follow up PR.
|
This is now part of moto >= 5.0.14.dev55 |
Implements describe, create, list, update, and delete virtual_node APIs