Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric support for image ratio prop #7085

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Add numeric support for image ratio prop #7085

merged 1 commit into from
Mar 25, 2025

Conversation

afbora
Copy link
Member

@afbora afbora commented Mar 21, 2025 •
edited by bastianallgeier
Loading

Enhancements

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added this to the 4.8.0 milestone Mar 21, 2025
@afbora afbora requested a review from a team March 21, 2025 20:50
@afbora afbora self-assigned this Mar 21, 2025
@afbora afbora linked an issue Mar 21, 2025 that may be closed by this pull request
Error for files field with both ratio and cover: true #7083
Closed
@afbora afbora force-pushed the fix/7083-image-ratio-numeric-support branch 2 times, most recently from ddc387f to 71c25f7 Compare March 21, 2025 21:02
@afbora afbora force-pushed the fix/7083-image-ratio-numeric-support branch from 71c25f7 to 2de6296 Compare March 21, 2025 21:11
@bastianallgeier bastianallgeier merged commit d31f1d9 into develop-minor Mar 25, 2025
13 checks passed
@bastianallgeier bastianallgeier deleted the fix/7083-image-ratio-numeric-support branch March 25, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Error for files field with both ratio and cover: true
2 participants
@afbora @bastianallgeier