Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support icon and info for query and api options #6783

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Nov 5, 2024

Description

@distantnative could you give me some insight into whether my implementation is correct before I add unit tests?

Changelog

Fixes

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added type: bug 🐛 Is a bug; fixes a bug needs: tests 🧪 Requires missing tests labels Nov 5, 2024
@afbora afbora self-assigned this Nov 5, 2024
@distantnative
Copy link
Member

Looks great and works as far as I can tell!

Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Do you need anything else to complete the PR?

@afbora afbora marked this pull request as ready for review November 11, 2024 13:05
@afbora afbora removed the needs: tests 🧪 Requires missing tests label Nov 11, 2024
@bastianallgeier bastianallgeier added this to the 4.5.0 milestone Nov 12, 2024
@bastianallgeier bastianallgeier merged commit 80f9dc0 into develop-minor Nov 12, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/6780-icon-query-support branch November 12, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants