Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version::isIdentical() #6781

Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 5, 2024

Description

Summary of changes

  • Added Version::isIdentical()
  • Removed Version::diff()
  • Using Version::isIdentical() to check if a changes version is still needed or identical with latest (in which case changes gets removed)

@distantnative distantnative self-assigned this Nov 5, 2024
@distantnative distantnative marked this pull request as ready for review November 5, 2024 17:04
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the changes.

@bastianallgeier bastianallgeier merged commit 58bd3b6 into v5/changes/develop Nov 6, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/version-is-identical branch November 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants