fix: don't use built in language in wasm

[ilevyor]

removes the use of the built_in_language in the yaml constructor as it will panic with unimplemented when run in a wasm environment

Summary by CodeRabbit

• Refactor
  • Renamed the function for identifying built-in languages for clarity.
  • Streamlined language identification process by integrating functionality directly into initialization.

[coderabbitai]

Walkthrough

The recent update streamlines the handling of languages in our YAML processing module. By renaming language() to built_in_language() and absorbing the id_for_kind() function's responsibilities into the Yaml struct's initialization, the change simplifies the codebase and enhances clarity, making it easier to understand and maintain.

Changes

File	Change Summary
crates/language/src/yaml.rs	Renamed language() to built_in_language(); Removed id_for_kind(), integrated its logic into Yaml struct initialization

🐰✨
In the realm of code, where logic intertwines,
A rabbit hopped through, making sleek designs.
"Rename and integrate," it said with a cheer,
Simplifying code, making its purpose clear.
Now, with every hop, and every clever tweak,
Our code grows stronger, more graceful and sleek.
🎉🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bd62cf9 and a7d06fb.

Files selected for processing (1)

• crates/language/src/yaml.rs (2 hunks)

Additional comments: 2

crates/language/src/yaml.rs (2)

• 14-20: The renaming of language() to built_in_language() and the use of conditional compilation based on the builtin-parser feature are well-implemented. However, adding documentation to explain the purpose of these two separate implementations could improve code readability and maintainability.
• 34-40: The direct use of language.id_for_node_kind() in the Yaml struct initialization, replacing the id_for_kind() function, simplifies the code and likely enhances compatibility with WASM environments. Ensure that all instances where id_for_kind() was previously used have been updated to this new approach.

Verification successful

---

The search for any remaining references to id_for_kind() in the Rust codebase did not produce any results, indicating that all instances of this function have been successfully replaced or removed as suggested. This confirms that the changes have been implemented correctly.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Search for any remaining references to `id_for_kind()` which should have been removed or replaced.
rg --type rust 'id_for_kind'

Length of output: 28