perf: remove im crate
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I've long wanted to remove this and it should be easy enough to adapt internally too. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
23 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
morgante
approved these changes
Oct 10, 2024
This was referenced Oct 10, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives rougly a 25-30% performance improvement on Biome's Grit benchmarks.
Heads-up: This changes a signature in api.rs. It looks like it should be easy enough for you to adapt, but let me know if you prefer me to revert to
imthere.There's a bunch of
.iter()=>as usizechanges that were unfortunately necessary due to ambiguities.Would be great if 0.4 of the crates can be released after merging this: #498
Greptile Summary
This is an auto-generated summary
API usage limit has reached your account's monthly budget. API requests will be rejected.