feat: add rewritten_text function

[morgante]

Add a second argument to text() to determine if we should linearize all current bindings before copying the text.

Summary by CodeRabbit

• New Features

  • Enhanced the text function to include a new linearize parameter, allowing for more control over text processing.
  • Introduced a new test function to validate text manipulation functionality.

• Bug Fixes

  • Improved functionality of text manipulation to ensure accurate transformations based on the new parameter.

Greptile Summary

This is an auto-generated summary

Added the rewritten_text function to enhance text processing capabilities.

• Modified /crates/util/fixtures/confusing.diff to replace keyBy and filter with groupBy from lodash.
• Updated reconstructDiff function in /crates/util/fixtures/confusing.diff to handle ranges instead of files and added context lines.
• Enhanced error handling and logging in reconstructDiff for better debugging.
• Adjusted file reading logic in /apps/minas/src/sdk/internal.ts to use join from node:path.
• Updated type definition in /packages/api/src/types.ts to reflect single range instead of ranges.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Walkthrough

Walkthrough

The recent changes enhance the text built-in function by adding a new parameter, linearize, which allows for the optional linearization of text. The control flow of the function has been modified to check this parameter, either processing the text through a linearization function or retrieving it directly. Additionally, a new test function has been introduced to validate the correct behavior of a related JavaScript function that transforms specific text patterns. Overall, these modifications improve the functionality and test coverage for text manipulation.

Changes

Files	Change Summaries
crates/core/src/built_in_functions.rs	Updated text_fn to include a linearize parameter, modifying its signature and control flow for text processing. Imports updated for memoization enhancements.
crates/core/src/test.rs	Introduced a new test function, linearized_text_fn, to validate text transformations performed by go_to_the_zoo.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BuiltIns
    participant LinearizedText

    User->>BuiltIns: Call text("input string", true)
    BuiltIns->>BuiltIns: Check if linearize is true
    alt Linearize is true
        BuiltIns->>LinearizedText: Call linearized_text(input string)
        LinearizedText-->>BuiltIns: Return processed text
    else Linearize is false
        BuiltIns-->>User: Return input string
    end
    BuiltIns-->>User: Return processed or original text

Loading

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 86b88bf and 2992d68.

Files selected for processing (2)

• crates/core/src/built_in_functions.rs (3 hunks)
• crates/core/src/test.rs (1 hunks)

Additional context used

Learnings (1)

Common learnings

Learnt from: morgante
URL: https://github.com/getgrit/gritql/pull/231

Timestamp: 2024-04-15T05:47:47.743Z
Learning: User morgante prefers not to be asked for documentation.

Additional comments not posted (7)

crates/core/src/built_in_functions.rs (5)

15-20: LGTM! Import changes are necessary.

The imports for CodeRange and HashMap are necessary for the memoization logic in the text_fn function.

---

147-147: LGTM! Updated function parameters are consistent.

The addition of the linearize parameter in the BuiltInFunction::new for the text function is consistent with the changes in the text_fn function.

---

251-254: LGTM! Linearization parameter check is correct.

The logic for checking the linearize parameter is correctly implemented.

---

255-258: LGTM! Conditional text retrieval is correct.

The conditional retrieval of text based on the linearize parameter is correctly implemented.

---

259-268: LGTM! Memoization logic is correctly implemented.

The memoization logic for linearized text is correctly implemented.

crates/core/src/test.rs (2)

6543-6543: LGTM!

The code changes are approved. The test function is well-structured and thorough.

---

6544-6578: Verify the usage of run_test_expected and TestArgExpected.

Ensure that the run_test_expected function and TestArgExpected type are correctly defined and used in the codebase.

Verification successful

---

Verification successful for run_test_expected and TestArgExpected.

Both run_test_expected and TestArgExpected are correctly defined and used within the crates/core/src/test.rs file. The function run_test_expected takes an argument of type TestArgExpected and utilizes its fields appropriately.

• run_test_expected function definition: crates/core/src/test.rs
• TestArgExpected struct definition: crates/core/src/test.rs

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `run_test_expected` and `TestArgExpected` in the codebase.

# Test: Search for the definitions and usages. Expect: Correct definitions and consistent usage.
rg --type rust -A 5 $'run_test_expected'
rg --type rust -A 5 $'TestArgExpected'

Length of output: 235391

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

LGTM

_{No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}