-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow running workflows with input from stdin #414
Conversation
WalkthroughWalkthroughThe recent changes enhance the visibility of certain fields within the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant FileSystem
participant MigrationExecutor
User ->> CLI: Execute command with PlumbingArgs::Run
CLI ->> FileSystem: Read input and locate workflow file
FileSystem -->> CLI: Return workflow file path
CLI ->> MigrationExecutor: Call run_apply_migration with workflow file and input
MigrationExecutor ->> CLI: Execute migration
CLI -->> User: Return migration result
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Additional context usedLearnings (1)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
&definition, | ||
) | ||
.await | ||
.unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 logic: Consider handling the potential error from find_workflow_file_from
instead of using unwrap()
.
Now input can be in a file, allowing arbitrarily large input params.
Greptile Summary
This is an auto-generated summary
input
andverbose
fields ofApplyMigrationArgs
public in/crates/cli/src/commands/apply_migration.rs
Run
subcommand toPlumbingArgs
enum in/crates/cli/src/commands/plumbing.rs
run_apply_migration
function for executing workflows with stdin inputSharedPlumbingArgs
for input handlingSummary by CodeRabbit