-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use thiserror
instead of anyhow
#410
Conversation
Could you please run the CI for me? Unfortunately, I can't run the tests internally because some source code requires rustic nightly for some features, which I don't have installed (the contribution guide doesn't say anything about it). |
Unfortunately looks like tests are failing. @ematipico Do you have more info on the rustic failure you're seeing? That wasn't a deliberate decision. |
Sure. I've had a couple of issues:
|
So if I understand correctly it’s because the |
c88776a
to
8948a1e
Compare
I really don't know, to be honest. This is a dependency that is pulled by a feature called |
Any help @morgante ? |
@ematipico I'm not sure about the root cause - do you want me to take over cleaning up this PR? |
The issue is caused by the feature By disabling that feature, I can run tests and run clippy. Can move forward with the PR, but I realised there's more work to do, especially in other crates. I will commit my changes so you can evaluate the entity of the changes. |
8948a1e
to
ae42d62
Compare
Hey @morgante, unfortunately the error occurred again and I can't compile the project. Not sure why. Feel free to take over the PR whenever you want |
Continued in #453 |
Closes #409