fix: refine patterns test --watch

[morgante]

Improve on #298 by:

• Making nicer terminal output
• Avoiding spawning blocking Tokio tasks, which is unsafe in some contexts
• Continuing to watch even when tests fail

Summary by CodeRabbit

• New Features

  • Introduced new pattern named simple_js_watch for JavaScript console log transformations.
  • Enhanced pattern analysis capabilities with new functions to find pattern dependents and definitions.

• Bug Fixes

  • Improved error handling in pattern test results and watch mode.

• Refactor

  • Renamed and updated test functions for better clarity and accuracy.
  • Adjusted function signatures and parameter types for improved function calls and result handling.

• Dependencies

  • Added futures version 0.3.29 to the project dependencies.

• Performance

  • Simplified and optimized function calls by removing unnecessary references.

Greptile Summary

This is an auto-generated summary

• Refined patterns test --watch in /crates/cli/src/commands/patterns_test.rs and /crates/cli/src/commands/plumbing.rs
• Deleted crates/cli_bin/fixtures/.grit/grit.yaml
• Added simple_js_watch pattern in /crates/cli_bin/fixtures/patterns_test/.grit/grit.yaml
• Improved test logic and output in /crates/cli_bin/tests/patterns_test.rs
• Introduced new functions for pattern dependency analysis in /crates/core/src/analysis.rs

[coderabbitai]

Warning

Rate limit exceeded

@morgante has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 93bfc37 and e45355e.

Walkthrough

Walkthrough

The recent updates primarily enhance the error handling, result aggregation, and pattern dependency detection features in the CLI and core analysis modules. A new enum, AggregatedTestResult, has been added to manage and communicate test outcomes more effectively, alongside changes to test result functions, watch mode behavior, and dependency traversal methods. Additionally, configuration, parser, and resolver functionalities were optimized for improved performance and maintainability.

Changes

Files and Paths	Change Summaries
crates/cli/src/commands/patterns_test.rs	Added AggregatedTestResult enum, changed get_marzano_pattern_test_results return type, improved test handling, and watch mode.
crates/cli/src/commands/plumbing.rs	Added error handling and result mapping to get_marzano_pattern_test_results.
crates/cli_bin/fixtures/patterns_test/.grit/grit.yaml	Introduced a new pattern simple_js_watch altering console log statements.
crates/cli_bin/tests/patterns_test.rs	Renamed test function and updated file paths/content modifications.
crates/core/src/analysis.rs	Added functions for pattern dependency detection and tree definition location.
crates/core/src/pattern_compiler/compiler.rs	Adjusted visibility of DefsToFilenames struct and fields, removed a function.
crates/gritmodule/Cargo.toml	Added a new dependency on futures version 0.3.29.
crates/gritmodule/src/config.rs	Changed parameter type in pattern_config_to_model function.
crates/gritmodule/src/parser.rs	Refactored PatternFileExt::Yaml branch for better error handling.
crates/gritmodule/src/resolver.rs	Simplified function calls by removing unnecessary references and methods.
crates/gritmodule/src/yaml.rs	Changed get_patterns_from_yaml to return BoxFuture using async move.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

LGTM

_{12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}