-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add .tfvars as a valid hcl file #401
Conversation
WalkthroughWalkthroughThe recent modifications to Changes
Sequence Diagram(s)The changes made don't include any new features or control flow modifications that necessitate a sequence diagram. The modification is a minor enhancement to the existing pattern matching for file extensions. Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably update it here too: https://github.com/getgrit/gritql/pull/401/files#diff-534b195f1ef2648e84ebd7aa39d99cf09cbbf15f06c1d48876ac595a4944c177R208
@morgante I just did an amend on the commit |
Result of a local run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failure looks unrelated.
@jaysonsantos Thank you for the contribution. |
Greptile Summary
This is an auto-generated summary
.tfvars
files as valid HCL files.tfvars
filesSummary by CodeRabbit
tfvars
, in addition tohcl
andtf
.