-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: watch mode for patterns test #298
Merged
Merged
Changes from 19 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
24535a7
feature: watch mode for patterns test
Ashu999 a4eae62
Merge branch 'main' of
Ashu999 3d6bd31
feat: re-run pattern test for changed/affected patterns only
Ashu999 d51ba5e
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 44fcd31
refactor: ignore watch mode on external libs and sepraton of concerns…
Ashu999 d5e0459
handle case when reading patterns from single yaml file
Ashu999 0a2fb53
watch mode made efficient and handled patten delete case
Ashu999 d63cfc6
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 d862cc8
remove clone() usage where possible
Ashu999 62ebf75
snapshot test update for yaml__tests__gets_module_patterns
Ashu999 266c58b
applied clippy fix
Ashu999 62ec2d3
improved code quality of watch mode functions
Ashu999 f8c4a32
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 472d374
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 d91a1f5
simplified code
Ashu999 ed2f881
added integration test for: patterns test --watch
Ashu999 a7968f7
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 5f26579
using temp directory for watch mode test
Ashu999 8df9a94
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 e73e73c
using get_fixture for temp directory setup
Ashu999 e28388d
watch mode logs minor fix
Ashu999 00d4119
added test for watch mode case when all patterns are removed
Ashu999 1ca1a43
avoid clone() and unwrap() where possible
Ashu999 7884371
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 5895757
use get_test_process_cmd() to get base command
Ashu999 43dc81e
Merge branch 'main' of https://github.com/getgrit/gritql into main-wa…
Ashu999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming the pattern name
our_cargo_use_long_dependency
.The current pattern name might be confusing. Consider renaming it to something more descriptive like
long_dependency_in_cargo_toml
.Committable suggestion