fix: markdown pattern invalid name message

[seren5240]

extend #151 to markdown patterns

Summary by CodeRabbit

• New Features

  • Introduced a pattern for more precise equality checks in JavaScript using Object.is.
  • Added a Button class to enhance UI components.

• Tests

  • New test to ensure commands with invalid names fail as expected.

• Bug Fixes

  • Added validation for pattern names in markdown files to prevent errors with invalid names.
  • Improved error handling in pattern chaining for better stability.

[coderabbitai]

Walkthrough

The changes enhance the codebase by introducing new patterns and tests, particularly focusing on JavaScript precision and error handling. A new pattern for JavaScript equality checks encourages using Object.is for -0 comparisons. Additionally, a Button class is introduced, and error handling is improved in pattern name validation and file resolution, ensuring robustness through specific test cases and error checks.

Changes

File Path	Change Summary
.../markdown_invalid_name/.../.grit/patterns/invalid-name.md	Introduces a pattern for precise JavaScript equality checks using Object.is.
.../markdown_invalid_name/test.js	Adds a Button class extending Component with an initialized property.
.../cli_bin/tests/apply.rs	Adds a test for commands with invalid names, ensuring they fail as expected.
.../gritmodule/src/markdown.rs	Adds validation for pattern names against a regex pattern, throwing an error for invalid names.
.../gritmodule/src/resolver.rs	Improves error handling in pattern and file resolution by using the ? operator.

🐰✨
In the code's garden, changes bloom,
Where Object.is dispels the gloom.
A Button sprouts, with care it's sown,
While tests ensure no error's grown.
With every line, our craft we hone.
🌟🌿

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 81442f1 and b5d1c48.

Files ignored due to path filters (1)

• crates/cli_bin/tests/snapshots/apply__markdown_pattern_with_invalid_name.snap is excluded by !**/*.snap

Files selected for processing (5)

• crates/cli_bin/fixtures/markdown_invalid_name/.grit/patterns/invalid-name.md (1 hunks)
• crates/cli_bin/fixtures/markdown_invalid_name/test.js (1 hunks)
• crates/cli_bin/tests/apply.rs (1 hunks)
• crates/gritmodule/src/markdown.rs (2 hunks)
• crates/gritmodule/src/resolver.rs (1 hunks)

Additional comments not posted (4)

crates/cli_bin/fixtures/markdown_invalid_name/test.js (1)

1-3: Assuming Component is a valid class within the project's context, this class definition looks good.

crates/gritmodule/src/markdown.rs (1)

406-408: The addition of pattern name validation using regex is a good practice for ensuring consistency in pattern names.

crates/gritmodule/src/resolver.rs (1)

561-562: Replacing unwrap_or_default() with the ? operator in error handling is an improvement, ensuring errors are properly propagated.

crates/cli_bin/tests/apply.rs (1)

2288-2305: The addition of the test markdown_pattern_with_invalid_name is correctly implemented and aligns with the project's testing conventions.

[coderabbitai]

Ensure sentences start with an uppercase letter for consistency and readability.

- tags: #SD
+ Tags: #SD

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change