fix: use matches instead of equals

[ilevyor]

fixes the failing tests on main, and changes CI to use on pull_request instead of pull_request_target

Summary by CodeRabbit

• Chores
  • Updated GitHub Actions workflows to trigger on pull_request events for enhanced code quality checks.

[coderabbitai]

Warning

Rate Limit Exceeded

@ilevyor has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 18 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0637bcb and ec6d364.

Walkthrough

The updates involve modifying GitHub Actions workflow triggers from pull_request_target to pull_request across various configuration files, enhancing the event handling for code quality checks and main branch operations. Additionally, there's an improvement in the ResolvedPattern logic within the codebase, adopting a more idiomatic Rust approach by utilizing the matches! macro for cleaner and more readable condition checks.

Changes

Files	Change Summary
.github/workflows/code-quality.yaml .github/workflows/main.yaml .github/workflows/pr-lint.yaml	Switched event trigger from pull_request_target to pull_request, with pr-lint.yaml also specifying opened and edited trigger types.
crates/core/src/.../resolved_pattern.rs	Updated logic for checking Constant::Undefined using matches! macro.

🐰✨
To the code we hop and leap,
Changing triggers, not missing a beat.
From target to request, we make the switch,
In patterns, a cleaner stitch.
Our code now flows like a cheerful song,
With each hop, we grow strong.
🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3581187 and 0637bcb.

Files selected for processing (4)

• .github/workflows/code-quality.yaml (1 hunks)
• .github/workflows/main.yaml (1 hunks)
• .github/workflows/pr-lint.yaml (1 hunks)
• crates/core/src/pattern/resolved_pattern.rs (1 hunks)

Additional comments not posted (4)

.github/workflows/pr-lint.yaml (1)

4-4: Switching the event trigger from pull_request_target to pull_request enhances security by limiting the execution context to the current PR. This is a good practice, especially for workflows that run on pull request events.

.github/workflows/code-quality.yaml (1)

5-5: Changing the event trigger to pull_request for the main branch is consistent with best practices for GitHub Actions, enhancing security and efficiency in handling PRs.

.github/workflows/main.yaml (1)

6-6: Modifying the event trigger to pull_request for the main branch aligns with security best practices for GitHub Actions workflows, ensuring that the CI process is both secure and efficient.

crates/core/src/pattern/resolved_pattern.rs (1)

884-884: Using the matches! macro for checking if a binding is Constant::Undefined improves code readability and maintainability. This is a more idiomatic way to perform pattern matching in Rust.

[arendjr]

I suppose you may need to force-push, since the test will keep failing until the fixed workflow is in main.