feat: inline container exclusion list #1693

spupuz · 2026-02-08T17:45:20Z

Thanks for the feedback! I've moved my changes to a new branch and synced my fork's main with upstream. Here's the new PR:

main...spupuz:arcane:feature/container-exclusion-prune-notifications

Let me know if there's anything else that needs adjustment!

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

Greptile Overview

Greptile Summary

This PR replaces the excluded-containers dropdown in the environment Jobs tab with an inline searchable list of containers using checkboxes, and adds a new autoUpdateExcludedContainers field to the settings update type. It also includes a small non-functional change to three notification provider forms (an extra comment line, already discussed in prior threads).

Confidence Score: 3/5

Moderately safe to merge, but UX/behavior around label-excluded containers likely needs adjustment.
Main functional change is localized to JobsTab. The new UI is straightforward, but it currently treats label-excluded containers as selected while disabling interaction, which can confuse users and makes the exclusion count include items they didn't choose. Other changes are minimal and type-only.
frontend/src/routes/(app)/environments/[id]/components/JobsTab.svelte

Important Files Changed

Filename	Overview
frontend/src/routes/(app)/environments/[id]/components/JobsTab.svelte	Replaced searchable select with inline searchable checkbox list for excluded containers; label-excluded containers are rendered as checked+disabled which can mislead users about what they configured.
frontend/src/routes/(app)/settings/notifications/providers/GenericProviderForm.svelte	Only change is an extraneous top-of-file comment (already noted in prior thread); otherwise no functional changes.
frontend/src/routes/(app)/settings/notifications/providers/GotifyProviderForm.svelte	Only change is an extraneous top-of-file comment (already noted in prior thread); otherwise no functional changes.
frontend/src/routes/(app)/settings/notifications/providers/SignalProviderForm.svelte	Only change is an extraneous top-of-file comment (already noted in prior thread); otherwise no functional changes.
types/settings/settings.go	Adds Update.AutoUpdateExcludedContainers field to settings types; appears straightforward.

…ications Prune Notifications: - Backend: Implemented Prune Report Notification logic and templates - Backend: Updated ScheduledPruneJob to send reports via NotificationService - Frontend: Added Prune Report Notification switch to Notification Settings - Frontend: Updated FormSchema and models to support prune notifications Container Exclusion: - Backend: Added AutoUpdateExcludedContainers setting - Backend: Updated UpdaterService to filter excluded containers - Frontend: Added AutoUpdateExcludedContainers to environment schema - Frontend: Added multi-select UI in Job Schedules tab for exclusions - Frontend: Fixed infinite loop in JobsTab state management - Frontend: Fixed missing icon import in JobsTab

- Fixed implicit any type in JobsTab.svelte container exclusion logic - Added autoUpdateExcludedContainers to Settings type definition

- Added logic to detect 'com.getarcaneapp.arcane.updater=false' label - Containers excluded by label are now shown as selected but disabled in the exclusion UI - Added visual indicator '(Label)' for these containers

Renamed helper functions per code review suggestion: - unmarshalConfig -> unmarshalConfigInternal - validateEmailConfig -> validateEmailConfigInternal - decryptDiscordToken -> decryptDiscordTokenInternal - decryptTelegramToken -> decryptTelegramTokenInternal - decryptEmailPassword -> decryptEmailPasswordInternal - renderTemplates -> renderTemplatesInternal - formatBytes -> formatBytesInternal

- Add AutoUpdateExcludedContainers field to settings.Update struct to fix 422 validation error - Replace dropdown with inline scrollable checkbox list for better multi-select UX - Add search input for filtering containers - Show excluded count badge next to section header - Revert unnecessary dropdown keep-open workarounds from SearchableSelect

…effect state mutation with derived pattern - Remove emoji from prune notification messages in notification_service.go - Rename unexported prune notification functions with Internal suffix - Fix indentation in NtfyProviderForm.svelte and PushoverProviderForm.svelte

github-actions · 2026-02-08T18:08:26Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed.

github-actions · 2026-02-08T18:08:27Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed.

spupuz · 2026-02-08T18:17:42Z

Merging upstream changes into my feature branch. Resolving conflicts by accepting upstream versions, as my features (Container Exclusion & Prune Notifications) have already been merged into the main project. This commit aligns my fork with the current codebase.

… in CI

…xclusion-prune-notifications

spupuz · 2026-02-08T20:42:16Z

Hey @mkendell, just pushed a fix for the merge conflicts in the provider forms (synced with main), so that should be sorted now. 🤞 Fingers crossed for the CI! I noticed some random timeouts with the linter earlier due to an upstream issue with the latest version, but hopefully it goes through this time. Let me know if it looks good!

spupuz · 2026-02-08T20:50:49Z

@kmendell all test are good ... or at least it seems

kmendell · 2026-02-08T23:29:35Z

@greptileai

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

frontend/src/routes/(app)/settings/notifications/providers/GenericProviderForm.svelte

greptile-apps · 2026-02-08T23:31:27Z

Additional Comments (1)

types/settings/settings.go
Setting added but unused

AutoUpdateExcludedContainers is added to types/settings.Update, but this PR doesn’t update any frontend settings model, API handler, or UI to actually read/write this field. As-is, the option won’t be surfaced or persisted anywhere, so the feature described by the PR title won’t work end-to-end.

Prompt To Fix With AI

This is a comment left during a code review.
Path: types/settings/settings.go
Line: 279:282

Comment:
**Setting added but unused**

`AutoUpdateExcludedContainers` is added to `types/settings.Update`, but this PR doesn’t update any frontend settings model, API handler, or UI to actually read/write this field. As-is, the option won’t be surfaced or persisted anywhere, so the feature described by the PR title won’t work end-to-end.

How can I resolve this? If you propose a fix, please make it concise.

kmendell · 2026-02-09T04:37:27Z

Is the whole fix just that one line? or was there supposed to be more?

spupuz · 2026-02-09T05:11:30Z

Is the whole fix just that one line? or was there supposed to be more?

Umh should have been more let me check.

spupuz · 2026-02-09T10:03:43Z

Hey @kmendell, just pushed an update to main (commit 9846346) that replaces the multi-select dropdown for excluded containers with a proper scrollable list + search. The dropdown was really annoying because it would close every time you selected a container, making it tedious to select multiple items. The new list fixes this. 🚀

kmendell · 2026-02-09T16:49:13Z

@greptileai

spupuz · 2026-02-09T17:29:38Z

@kmendell i just forgot to put a small counter for excluded containers
i can add it if you want

spupuz · 2026-02-09T17:42:05Z

@kmendell Just pushed an update to feature/container-exclusion-prune-notifications. I added a live count to the "Excluded Containers" label so it's easier to see how many are ignored at a glance (including the label-based ones).

stavros-k · 2026-02-09T19:37:30Z

This might also benefit from some label per container in stacks!
ie arcane.auto-update: false.

spupuz · 2026-02-09T19:40:07Z

This might also benefit from some label per container in stacks!
ie arcane.auto-update: false.

Already implemented

kmendell · 2026-02-10T01:02:21Z

This might also benefit from some label per container in stacks! ie arcane.auto-update: false.

This has been a feature since i made the auto updater:

https://getarcane.app/docs/guides/updates

com.getarcaneapp.arcane.updater=false is the label

kmendell · 2026-02-10T01:02:34Z

@greptileai

frontend/src/routes/(app)/environments/[id]/components/JobsTab.svelte

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-10T01:05:12Z

Additional Comments (1)

frontend/src/routes/(app)/environments/[id]/components/JobsTab.svelte
Disabled items are pre-selected

mapContainerToItem() marks label-excluded containers as selected (excludedContainers.has(name) || labelExcluded) while also setting disabled: labelExcluded. In the UI this renders a checked-but-disabled checkbox, which can’t be unchecked and also gets counted as “excluded” even if the user never chose it. If label exclusion is meant to be informational/override, it should probably not force selected, or the UI should distinguish “excluded by label” vs “excluded by setting” so users don’t think they configured it.

Prompt To Fix With AI

This is a comment left during a code review.
Path: frontend/src/routes/(app)/environments/[id]/components/JobsTab.svelte
Line: 166:176

Comment:
**Disabled items are pre-selected**

`mapContainerToItem()` marks label-excluded containers as `selected` (`excludedContainers.has(name) || labelExcluded`) while also setting `disabled: labelExcluded`. In the UI this renders a checked-but-disabled checkbox, which can’t be unchecked and also gets counted as “excluded” even if the user never chose it. If label exclusion is meant to be informational/override, it should probably not force `selected`, or the UI should distinguish “excluded by label” vs “excluded by setting” so users don’t think they configured it.

How can I resolve this? If you propose a fix, please make it concise.

- Refactored JobsTab.svelte to not force selection for label-excluded containers - Updated container count logic to exclude label-excluded containers - Added missing i18n strings for auto-update exclusion description and label - Replaced hardcoded 'No results' strings with 'common_no_results_found'

spupuz · 2026-02-10T10:40:01Z

@mkendell, here is a concise summary of the work:

UI Refactor & i18n (Commit: `98c9ada`)

New List View: Replaced the exclusion dropdown with a scrollable checklist and real-time search.
Label Handling: Containers excluded via Docker labels are now disabled, marked with (Label), and no longer included in the manual exclusion count.
i18n: Moved all hardcoded strings to en.json using paraglide-js.

Backend Linter Investigation

Zero Backend Changes: Confirmed no Go changes compared to main in this branch.
Local Verification: golangci-lint passes locally with CI config (0 issues).
CI Diagnosis: The "2 errors" in CI appear to be environment-related (likely a missing dist folder for //go:embed) and unrelated to the changes in this PR.

spupuz and others added 17 commits February 2, 2026 11:55

fix(prune): duplicate accounting of container space in PruneAll

2cd8b76

fix(frontend): resolve CI build errors

4bf7340

- Fixed implicit any type in JobsTab.svelte container exclusion logic - Added autoUpdateExcludedContainers to Settings type definition

Merge branch 'main' into main

1aeb9da

feat(frontend): visualize label-based auto-update exclusions

88c4d85

- Added logic to detect 'com.getarcaneapp.arcane.updater=false' label - Containers excluded by label are now shown as selected but disabled in the exclusion UI - Added visual indicator '(Label)' for these containers

feat: sync label exclusions to UI and improve error handling in JobsTab

bd3d100

fix(backend): add missing switch case for PruneReport notification

14bf60c

Merge branch 'main' into main

49af2db

command fixes

aa333ef

i18n: add translation keys for container exclusion labels in JobsTab

7216628

Merge branch 'main' into main

fb08f5b

fix: format files with goimports

1965953

Merge branch 'main' into main

a90ec2c

Merge branch 'main' into main

003e517

spupuz requested a review from a team February 8, 2026 17:45

graphite-app bot assigned spupuz Feb 8, 2026

github-actions bot added the merge conflict label Feb 8, 2026

Merge branch 'main' into feature/container-exclusion-prune-notifications

01d8f42

github-actions bot removed the merge conflict label Feb 8, 2026

spupuz added 5 commits February 8, 2026 20:49

Fix remaining merge conflicts in provider forms

096320d

Pin golangci-lint version to v1.61.0 in CI to avoid schema timeout

4628f5f

Revert: Pin golangci-lint version to v1.61.0

c457ad5

Force update of provider forms to resolve persistent conflict markers…

a25c35a

… in CI

Merge remote-tracking branch 'upstream/main' into feature/container-e…

ca9be2b

…xclusion-prune-notifications

kmendell changed the title ~~Feature/container exclusion prune notifications~~ feat: inline container exclusion list Feb 8, 2026

kmendell changed the title ~~feat: inline container exclusion list~~ fix: add missing container exclusion option Feb 8, 2026

greptile-apps bot reviewed Feb 8, 2026

View reviewed changes

frontend/src/routes/(app)/settings/notifications/providers/GenericProviderForm.svelte Show resolved Hide resolved

spupuz added 2 commits February 9, 2026 09:58

Merge branch 'main' into feature/container-exclusion-prune-notifications

3861884

feat(ui): replace excluded containers dropdown with searchable list

9846346

kmendell changed the title ~~fix: add missing container exclusion option~~ feat: inline container exclusion list Feb 9, 2026

feat(ui): add count to excluded containers label

c4a9112

kmendell requested changes Feb 10, 2026

View reviewed changes

greptile-apps bot reviewed Feb 10, 2026

View reviewed changes

Uh oh!

feat: inline container exclusion list #1693

Are you sure you want to change the base?

feat: inline container exclusion list #1693

Uh oh!

Conversation

spupuz commented Feb 8, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

github-actions bot commented Feb 8, 2026

Uh oh!

github-actions bot commented Feb 8, 2026

Uh oh!

spupuz commented Feb 8, 2026

Uh oh!

spupuz commented Feb 8, 2026

Uh oh!

spupuz commented Feb 8, 2026

Uh oh!

kmendell commented Feb 8, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot commented Feb 8, 2026

Uh oh!

kmendell commented Feb 9, 2026

Uh oh!

spupuz commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spupuz commented Feb 9, 2026

Uh oh!

kmendell commented Feb 9, 2026

Uh oh!

spupuz commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spupuz commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stavros-k commented Feb 9, 2026

Uh oh!

spupuz commented Feb 9, 2026

Uh oh!

kmendell commented Feb 10, 2026

Uh oh!

kmendell commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 10, 2026

Uh oh!

spupuz commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UI Refactor & i18n (Commit: 98c9ada)

Backend Linter Investigation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spupuz commented Feb 8, 2026 •

edited by greptile-apps bot

Loading

spupuz commented Feb 9, 2026 •

edited

Loading

spupuz commented Feb 9, 2026 •

edited

Loading

spupuz commented Feb 9, 2026 •

edited

Loading

spupuz commented Feb 10, 2026 •

edited

Loading

UI Refactor & i18n (Commit: `98c9ada`)