fix: Improve mobile layout for ZapPlanner page #1821
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Oct 14, 2025
| <Badge | ||
| variant="positive" | ||
| className="flex items-center gap-1" | ||
| className="hidden md:flex items-center gap-1" |
Contributor
There was a problem hiding this comment.
I don't like so much that we have to duplicate the badge. It was solved in another way here if you would like to have a look: https://github.com/getAlby/hub/blob/master/frontend/src/screens/apps/AppDetails.tsx#L194
rolznz
reviewed
Oct 14, 2025
| /> | ||
| </DialogTrigger> | ||
| <DialogContent className="sm:max-w-[600px]"> | ||
| <DialogContent className="sm:max-w-[600px] max-h-[85vh] overflow-y-auto"> |
Contributor
There was a problem hiding this comment.
I wonder if these should be actually be set everywhere we use dialog content. Since it's a shadcn component it's best we don't edit it directly, but we could add a ResponsiveDialogContent class that renders DialogContent, and put that one in our custom components. What do you think? CC @reneaaron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1816 and fixes #1817
also noticed irresponsiveness of the modal on small screens.
before
after