Skip to content

feat: improve f&f #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 11, 2025
Merged

feat: improve f&f #1130

merged 27 commits into from
Apr 11, 2025

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Feb 25, 2025

  • Separation of sub-wallets and isolated apps
  • Sub-wallet integration in main menu
  • Improved sub-wallet connection page
  • Total assets under management

Fixes #1131, #1112, #1091

TODOs

  • Replace darkmode image + optimize SVGs
  • add padding for store qr codes
  • Use standard avatars instead of f&f logo for cards?
  • Fix delete flow (returning to connections page)

@reneaaron reneaaron force-pushed the feat/friendsandfamily-improvements branch from 70d262d to a1479d5 Compare February 26, 2025 14:12
@stackingsaunter
Copy link
Contributor

stackingsaunter commented Feb 27, 2025

@reneaaron

Use standard avatars instead of f&f logo for cards?

Maybe we can have a custom icon, that generates BGs same as standard avatars, but also has a wallet on it?

Although If we have "sub-wallet" tag in the card then maybe let's keep for now just original avatars.

@bumi bumi requested a review from Copilot April 6, 2025 13:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

@reneaaron reneaaron changed the title [WIP] feat: improve f&f feat: improve f&f Apr 8, 2025
@reneaaron reneaaron requested a review from im-adithya April 8, 2025 12:01
@reneaaron reneaaron marked this pull request as ready for review April 8, 2025 12:01
@im-adithya
Copy link
Member

When I try to create a new connection I still see Sub-wallet instead of Isolated, should we change this?

Screenshot 2025-04-08 at 7 07 28 PM

@im-adithya
Copy link
Member

This looks super cool!

Screenshot 2025-04-08 at 7 18 16 PM

@reneaaron
Copy link
Contributor Author

When I try to create a new connection I still see Sub-wallet instead of Isolated, should we change this?
Screenshot 2025-04-08 at 7 07 28 PM

Missed that one, will update 👌

@im-adithya
Copy link
Member

Looks good, just needs this important change and then will approve (since that makes everything unusable 😅)

@im-adithya
Copy link
Member

I think we just need this to be fixed and can then merge?

@rolznz
Copy link
Contributor

rolznz commented Apr 10, 2025

For me the padding feels off, it's too close to the sidebar.

image

@reneaaron
Copy link
Contributor Author

For me the padding feels off, it's too close to the sidebar.

I felt similar, however that's the new sidebar design. Let's see what @stackingsaunter thinks if he sees the new spacing in action.

Copy link
Member

@im-adithya im-adithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit 27628df into master Apr 11, 2025
11 checks passed
@reneaaron reneaaron deleted the feat/friendsandfamily-improvements branch April 11, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Friends & Family" app to the Home page
4 participants