Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): [Transaction] add basic transaction amount input #93

Merged
merged 1 commit into from
Jul 11, 2024
Merged

feat(mobile): [Transaction] add basic transaction amount input #93

merged 1 commit into from
Jul 11, 2024

Conversation

bkdev98
Copy link
Member

@bkdev98 bkdev98 commented Jul 9, 2024 •
edited
Loading

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-09.at.17.59.54.mp4

@bkdev98 bkdev98 requested a review from duongdev July 9, 2024 11:01
@bkdev98 bkdev98 added the enhancement New feature or request label Jul 9, 2024 — with Graphite App
@bkdev98 Graphite App
Copy link
Member Author

bkdev98 commented Jul 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bkdev98 and the rest of your teammates on Graphite Graphite

@bkdev98 bkdev98 marked this pull request as ready for review July 9, 2024 11:01
@duongdev
Copy link
Member

duongdev commented Jul 9, 2024 •
edited
Loading

The VND and numbers are overflow during animation

CleanShot 2024-07-09 at 18 25 31@2x

@bkdev98 bkdev98 force-pushed the 07-09-feat_mobile_add_basic_transaction_amount_input branch from 83ccf2c to e773c86 Compare July 9, 2024 12:40
@bkdev98 bkdev98 force-pushed the 07-09-feat_mobile_add_basic_transaction_amount_input branch from e773c86 to 9128486 Compare July 9, 2024 12:43
@bkdev98
Copy link
Member Author

bkdev98 commented Jul 9, 2024

The VND and numbers are overflow during animation

CleanShot 2024-07-09 at 18 25 31@2x

Fixed 🔧

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-09.at.19.43.22.mp4

@bkdev98 bkdev98 force-pushed the 07-09-feat_mobile_add_basic_transaction_amount_input branch from 9128486 to ef17ad6 Compare July 9, 2024 12:51
@bkdev98 bkdev98 mentioned this pull request Jul 9, 2024
Merged
@bkdev98 bkdev98 force-pushed the 07-09-feat_mobile_add_basic_transaction_amount_input branch from ef17ad6 to bc5b42e Compare July 10, 2024 09:43
@bkdev98 bkdev98 force-pushed the 07-09-feat_mobile_add_basic_transaction_amount_input branch from bc5b42e to efd3712 Compare July 10, 2024 11:34
@bkdev98 bkdev98 mentioned this pull request Jul 10, 2024
Merged
@bkdev98 bkdev98 changed the title feat(mobile): add basic transaction amount input feat(mobile): [Transaction] add basic transaction amount input Jul 10, 2024
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@duongdev Graphite App
Copy link
Member

duongdev commented Jul 11, 2024 •
edited
Loading

Merge activity

  • Jul 10, 11:51 PM EDT: @duongdev started a stack merge that includes this pull request via Graphite.
  • Jul 10, 11:51 PM EDT: @duongdev merged this pull request with Graphite.

@duongdev duongdev merged commit af42cec into main Jul 11, 2024
4 checks passed
@duongdev duongdev deleted the 07-09-feat_mobile_add_basic_transaction_amount_input branch July 11, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duongdev duongdev duongdev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
6pm
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkdev98 @duongdev