Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing structure for dbt Labs testing support - postgres #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmyoop
Copy link

@emmyoop emmyoop commented Oct 11, 2024

Resolve #32

This PR make a slight update to the current testing layout to allow dbt Labs to start testing this package as part of our own
release process.

I have left your current tests in place while modifying them slightly. A large portion of this PR is just renaming existing vars and folders. The actual additional functionality is rather small.

Why Do We Need These Changes

As explained in #32, by setting up tox as a standard entry-point, the Core development team at dbt Labs can include this package's integration tests (along with other popular dbt packages) as part of our continuous development & delivery of dbt.

@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:52 — with GitHub Actions Failure
@emmyoop emmyoop changed the title Update testing structure for dbt testing support Update testing structure for dbt Labs testing support Oct 11, 2024
@emmyoop emmyoop changed the title Update testing structure for dbt Labs testing support Update testing structure for dbt Labs testing support - postgres Oct 11, 2024
@NiallRees
Copy link
Member

Hey @emmyoop - I just appproved the tests, looks like they're failing from this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tox-based Integration Testing support for this package
2 participants