Skip to content

Commit

Permalink
[Tracing] Add tracing to functions in Isolate::run (#24558)
Browse files Browse the repository at this point in the history
There are some missing spans in `Isolate::run` so this aims to capture some of the missing execution time.

GitOrigin-RevId: baea64010a124a53fac037cfaa4e3069490f2189
  • Loading branch information
jordanhunt22 authored and Convex, Inc. committed Apr 11, 2024
1 parent f363edc commit ef15827
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions crates/isolate/src/isolate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ impl<RT: Runtime> Isolate<RT> {
Ok(())
}

#[minitrace::trace]
pub async fn start_request<E: IsolateEnvironment<RT>>(
&mut self,
environment: E,
Expand Down
1 change: 1 addition & 0 deletions crates/isolate/src/request_scope.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ impl<RT: Runtime, E: IsolateEnvironment<RT>> RequestState<RT, E> {
}

impl<'a, 'b: 'a, RT: Runtime, E: IsolateEnvironment<RT>> RequestScope<'a, 'b, RT, E> {
#[minitrace::trace]
pub async fn new(
scope: &'a mut v8::HandleScope<'b>,
handle: IsolateHandle,
Expand Down

0 comments on commit ef15827

Please sign in to comment.