introduce ionex2kml tool #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
lnicola
reviewed
Aug 12, 2023
| ======================== | ||
|
|
||
| When converting to KML, we round the TEC values and shrink it to N equipotential areas. | ||
| In other words, the granularity on the TEC visualization you get is max|tec|/N where max|tec| |
There was a problem hiding this comment.
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/writing-mathematical-expressions might make this easier to read.
There was a problem hiding this comment.
Do you know if we can use latex like equations in docrs too ? At the time I looked at it, there was a tweak involving storing html pages if I remember correctly, seemd too complicated
There was a problem hiding this comment.
lnicola
reviewed
Aug 12, 2023
lnicola
reviewed
Aug 12, 2023
| Self { | ||
| matches: { | ||
| Command::new("ionex2kml") | ||
| .author("Guillaume W. Bres, <[email protected]>") |
There was a problem hiding this comment.
lnicola
reviewed
Aug 12, 2023
| /// Returns optional <String, String> "KML attributes" | ||
| pub fn kml_attributes(&self) -> Option<HashMap<String, String>> { | ||
| if let Some(attributes) = self.matches.get_one::<String>("attributes") { | ||
| let content: Vec<&str> = attributes.split(",").collect(); |
There was a problem hiding this comment.
Doesn't matter, but this isn't a great way to write this.
Co-authored-by: Laurențiu Nicola <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
ionex2kmlcommand line tool, to convert IONEX data to KML format.KML files can be visualized with many third party tools and that offers another option to visualize IONEX.
KML supports the description of bounded areas, so we can totally describe TEC iso surfaces as contained in IONEX