Replace strlcat symbol in vendored netcdf source code with a prefixed version
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
fix/duplicated_strlcat_symbol
branch
from
2923099
to
3e783cf
Compare
|
Thanks! Just released |
|
Thanks for the fast turnaround ❤️ That's really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another patch to the vendored version of the netcdf source code to replace the
strlcatsymbol with vendored version to prevent duplicated symbols at the linking stage if any other dependency also includes a vendored version ofstrlcat. This is essentially Unidata/netcdf-c#2906, but adjusted to the vendored version (the function definition is in a different file). I found this issue while working on the CI setup for georust/gdal#517 (that PR is essentially blocked on this one now…)