Catch potential null pointers returned by Dataset::spatial_ref
#540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
May 21, 2024
|
Can you also add an |
weiznich
force-pushed
the
fix/null_ptr_in_dataset_get_spatial_ref
branch
from
329a776
to
2131b78
Compare
lnicola
reviewed
May 21, 2024
This otherwise hits an assertion in gdal debug builds for the OSRClone method
weiznich
force-pushed
the
fix/null_ptr_in_dataset_get_spatial_ref
branch
from
2131b78
to
d2415a5
Compare
|
Thanks, will merge once GHA comes back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This otherwise hits an assertion in gdal debug builds for the OSRClone method
CHANGES.mdif knowledge of this change could be valuable to users.See https://github.com/OSGeo/gdal/blob/master/ogr/ogrspatialreference.cpp#L1406 for the relevant assertion in gdal