build: no bindings: make error more explicit #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Maybe we should go for something simpler like "Enable the |
|
Disclaimer: I know nothing about gdal-rs ;-) I think it'd be great to distinguish GDAL from the rust crate. To be honest I thought the message was related to the gdal library. Maybe something like "Enable the If that's okay with you I can change the MR. |
|
I mean sure, but GDAL is GDAL and |
The panic that arises when there are no pre-build bindings available is not that explicit and may confuse some users into thinking there's something wrong with GDAL. Signed-off-by: Frank Villaro-Dixon <[email protected]>
lnicola
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The panic that arises when there are no pre-build bindings available is not that explicit and may confuse some users into thinking there's something wrong with GDAL.
Thanks!
CHANGES.mdif knowledge of this change could be valuable to users.