-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up spatial_ref
module into feature-focused submodules.
#395
Conversation
0cb95fa
to
ccf5971
Compare
I didn't look at the other changes, but I don't think that function should be unsafe. I filed #360 for that, which.. you've already seen? 😄 |
Ah! I misread your ticket!... and thought you were saying the opposite 🤦 I defer to your experience here. I'll remove it here, and we can create a new PR to handle the other cases.... or find an all around better way. |
ccf5971
to
0099c26
Compare
CHANGES.md
Outdated
@@ -81,6 +81,10 @@ | |||
|
|||
- <https://github.com/georust/gdal/pull/370> | |||
|
|||
- Split `spatial_ref` module into more feature-specific submodules. (Public API is unchanged.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if users will care about this :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these refactoring and documentation PRs, I think they're great!
0099c26
to
f41b745
Compare
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
CHANGES.md
if knowledge of this change could be valuable to users.Also added small bits of documentation and fixed clippy warnings.
Aside: I originally started this refactor because I'm about to expose the GCP API and erroneously thought it would be a part of the
spatial_ref
API. But now I see it's onlyraster
-related. Therefore, this is basically some simple house-keeping...