-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows tests #341
Fix windows tests #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actually able to test on a Windows computer, so my review is only source-level. 😄
Implemented fixes. I can't test on Windows at the moment, but I can test tomorrow. |
#218 disables all broken tests, so it did run fine back then. |
The issues with
My solution was to put the open |
bors r+ |
Build succeeded: |
CHANGES.md
if knowledge of this change could be valuable to users.