chore: switch image parameter to dedicated section #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
edevosc2c
commented
Mar 20, 2025
edevosc2c
commented
- Switch to a dedicated image section:
- Allows to keep the default parameter from the upstream helm chart. Like repository, this way if a change in made where the docker image is hosted, all the infra will get these changes by just updating the helm chart.
- Switch to pullPolicy IfNotPresent in order to avoid by default pulling a new helm chart when unnecessary (production for example).
edevosc2c
force-pushed
the
improve-image-parameter
branch
from
8d177e7 to
fa01cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.