Skip to content

Use JSON-LD link if found for HTML injection #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

webb-ben
Copy link
Member

@webb-ben webb-ben commented Mar 6, 2025

Overview

Use JSON-LD link if found during link creation to render JSON-LD in default HTML templates. For requests that require a parameter like EDR, pygeoapi throws an error when trying to inject the JSON-LD to the HTML template because it does not include the necessary query arguments. This PR updates the behavior such that if a JSON-LD link is found, it is then subsequently used to fetch the json-ld that is injected because it will contain the additional query arguments to fetch the appropriate url.

Related Issue / discussion

#859
cgs-earth/Western-Water-Datahub-Mappings#16

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Sorry, something went wrong.

@webb-ben webb-ben added bug Something isn't working ui User interface linked data Linked data (schema.org/JSON-LD) labels Mar 6, 2025
@webb-ben webb-ben requested a review from tomkralidis March 6, 2025 17:57
@webb-ben webb-ben force-pushed the opportunistic-jsonld branch from 47c6e59 to 40f1bbd Compare March 6, 2025 18:01
@webb-ben webb-ben force-pushed the opportunistic-jsonld branch from 40f1bbd to 9762bbf Compare March 6, 2025 18:13
Copy link

github-actions bot commented Jun 8, 2025

This Pull Request has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Jun 8, 2025
Copy link

As per RFC4, this Pull Request has been closed due to there being no activity for more than 90 days.

@github-actions github-actions bot closed this Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linked data Linked data (schema.org/JSON-LD) stale Issue marked stale by stale-bot ui User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant