Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/update-raster #162

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Hotfix/update-raster #162

merged 4 commits into from
Jun 30, 2024

Conversation

krishnaglodha
Copy link
Member

Updated coverages to work with local Tartu NTL data

Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishnaglodha changes requested. Also, the exercise text (https://github.com/geopython/diving-into-pygeoapi/blob/main/workshop/content/docs/publishing/ogcapi-coverages.md) needs to be updated to reflect the new coverage data sample.

workshop/exercises/pygeoapi.config.yml Show resolved Hide resolved
workshop/exercises/pygeoapi.config.yml Outdated Show resolved Hide resolved
Copy link
Member

@justb4 justb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When review comments from @tomkralidis resolved GTG!

@justb4 justb4 added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 27, 2024
@justb4
Copy link
Member

justb4 commented Jun 30, 2024

Looks good now. For my understanding: I run the exercise but apart from the data extent I don't see any raster data rendering from the GeoTIFF in the demo page: http://localhost:5000/collections/tartu-ntl . Or is that not intended (same I see now with Firenze data from 2022)?

@tomkralidis
Copy link
Member

@justb4 correct, We are not rendering coverages. I will do a final review and merge later today.

@tomkralidis tomkralidis merged commit 03bf524 into main Jun 30, 2024
1 check passed
@tomkralidis tomkralidis deleted the hotfix/update-raster branch June 30, 2024 18:49
tomkralidis added a commit that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants