Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated repo to resolve #117 #118

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Updated repo to resolve #117 #118

merged 6 commits into from
Dec 7, 2023

Conversation

krishnaglodha
Copy link
Member

Added following things

  1. Data for work with
  2. Updated config.yml
  3. Added leaflet.html to see data
  4. update dive doc to mention the config we need to add

This was referenced Dec 6, 2023
Closed
Closed
doublebyte1
doublebyte1 requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@doublebyte1 doublebyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. The example works, but it needs some polishing.
The explanation on the OGC API - Maps section needs to be a bit more elaborated, in order for the students to be able to run the example.

workshop/content/docs/publishing/ogcapi-maps.md Outdated Show resolved Hide resolved
workshop/exercises/docker-compose.yml Outdated Show resolved Hide resolved
workshop/exercises/html/leaflet.html Outdated Show resolved Hide resolved
workshop/exercises/pygeoapi.config.yml Outdated Show resolved Hide resolved
workshop/exercises/html/leaflet.html Outdated Show resolved Hide resolved
doublebyte1
doublebyte1 requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@doublebyte1 doublebyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to read this section and do something similar in terms of content and formatting.

workshop/content/docs/publishing/ogcapi-maps.md Outdated Show resolved Hide resolved
workshop/content/docs/publishing/ogcapi-maps.md Outdated Show resolved Hide resolved
workshop/content/docs/publishing/ogcapi-maps.md Outdated Show resolved Hide resolved
@doublebyte1
Copy link
Contributor

Shapefile is not a standard format. If possible, it would be better to use a geopackage, instead. You can use GDAL or QGIS to convert a Shapefile into Geopackage.

@doublebyte1
Copy link
Contributor

Not sure where we use the airports.csv file?

@krishnaglodha
Copy link
Member Author

Not sure where we use the airports.csv file?

I was planning to use it in "Indian-centric" data sets

@doublebyte1 doublebyte1 merged commit b142f50 into main Dec 7, 2023
1 check passed
@tomkralidis tomkralidis deleted the geopython/issue-117 branch December 11, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doublebyte1 doublebyte1 doublebyte1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
GISE Hub Winter School on OGC Stack 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@krishnaglodha @doublebyte1 @tomkralidis