Skip to content

Conversation

@davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Feb 3, 2025

Description

Fixes #352.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--425.org.readthedocs.build/en/425/
💡 JupyterLite preview: https://jupytergis--425.org.readthedocs.build/en/425/lite

@davidbrochart davidbrochart marked this pull request as draft February 3, 2025 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Binder 👈 Launch a Binder on branch davidbrochart/jupytergis/file-path

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Integration tests report: appsharing.space

@davidbrochart
Copy link
Collaborator Author

This is not the final solution, but using a backend absolute path and passing that to the frontend cannot work in the general case.

@davidbrochart davidbrochart mentioned this pull request Feb 3, 2025
4 tasks
@martinRenou martinRenou added the bug Something isn't working label Feb 3, 2025
@martinRenou
Copy link
Member

Thanks @davidbrochart !

Well, CI is passing and testing the Python API from the notebook. Let's merge?

@davidbrochart
Copy link
Collaborator Author

CI is passing and testing the Python API from the notebook. Let's merge?

Hmm I think the examples/Notebook.ipynb doesn't work with this change?

@martinRenou
Copy link
Member

We're supposed to have visual regression tests running this notebook, I'm not sure why it doesn't complain

@davidbrochart
Copy link
Collaborator Author

Maybe Jupyter is launched inside examples in the CI?

@martinRenou
Copy link
Member

Closing as it's already included as part of #412

@martinRenou martinRenou closed this Feb 6, 2025
@davidbrochart davidbrochart deleted the file-path branch February 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kernel file path relative to JupyterLab drive's root directory

2 participants