Make entropy nonlinear solver tests converge #6655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase, please? |
gassmoeller
force-pushed
the
update_entropy_tests
branch
from
497816e to
95a94a8
Compare
gassmoeller
changed the title
|
I rebased and updated the test results. There is still one timestep where the nonlinear solver does not converge at all (the last timestep of test 8b_enthalpy_with_boundary_heating_and_phase_change), but I am not too concerned about it. It stagnates at a residual of 0.000539752. |
tjhei
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nonlinear solver in these tests eventually converges, but it needs more iterations than are currently allowed. This change will make sure the solver converges without warning. This should reduce small differences in the results during updates to the tester system.
This should be merged after #6608 and #6638.