Feature 133 #153
Closed
Feature 133 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not fully working yet. Need to : - add a 'screening_inclusion_mode' row in the 'config' table in database. - edit the 'update_config_screening' procedure to account for the new row. - add the screening logic for the different modes.
still need to : - Remove the "Select..." field when choosing criteria. - Think about changes in database in the case of selecting multiple criteria.
Also removed the "Select..." option when choosing multiple criteria with the "Any" inclusion mode, because it used to count as a criteria in the $inclusion_criteria array. Still need to fix the checkbox in the "All" mode. Will focus on improving UI as the last step. Next to do is adding the mapping table in the database.
…y" inclusion mode Also improved the display code of the different modes using a switch case
Also, saving multiple criteria under the 'Any' mode is now a transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new setting 'Inclusion mode' in the screening phase. Can be set to: