mpv-plugin/SimpleHistory: new package #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaly-zdanevich
force-pushed
the
mpv-plugin/SimpleHistory
branch
from
a023e50 to
da15a6d
Compare
N-R-K
suggested changes
Apr 12, 2025
| pkg_postinst() { | ||
| mpv-plugin_pkg_postinst | ||
| einfo "h to see the history, ctrl-r to resume previously closed" | ||
| einfo "Documentation https://github.com/Eisa01/mpv-scripts#simplehistory" |
There was a problem hiding this comment.
It should install the readme, not link to it via url.
Docs should also include the example .conf file.
Underneath MPV_PLUGIN_FILES you can add DOCS=( script-opts/SimpleHistory.conf README.md ) which probably should work.
There was a problem hiding this comment.
Thanks for the review - added DOCS.
I love einfo with some short advices and a link, this is useful for people.
vitaly-zdanevich
force-pushed
the
mpv-plugin/SimpleHistory
branch
from
da15a6d to
817317a
Compare
Signed-off-by: Vitaly Zdanevich <[email protected]>
vitaly-zdanevich
force-pushed
the
mpv-plugin/SimpleHistory
branch
from
817317a to
42276b6
Compare
N-R-K
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.