[fix] type cast: pointer truncation, x64 build #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gentilkiwi,
trying to build mimikatz (Release|x64) with Visual Studio Community 2019, I got the error you can see in the screenshot below
I tried to solve it by changing where necessary the code.
By applying these changes I no longer get errors/warnings with both x64 and Win32. It would be necessary to understand if at runtime the result is the expected one or not.
Do you have any way to verify this for yourself? I could try it myself but I think it's better to leave this task to you :D
Let me know, thanks :)