adding a modal with project rejection #554 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not finished
|
@mboudet this one can be reviewed |
mboudet
reviewed
Jan 14, 2025
|
|
||
| openRejectModal(project: any, user_uid: any) { |
There was a problem hiding this comment.
Any point in having user_uid? I'm not sure you actually use it anywhere?
Comment on lines
+338
to
+347
| if(this.rejectionReason) | ||
| this.userService.notify(this.currentProject.owner, { | ||
| subject: `: Project ${this.currentProject.id} creation rejected`, | ||
| message: `The reason why your project was not accepted by one of our admins is the following: ${this.rejectionReason}`, | ||
| send_copy_to_support: this.sendCopyToSupport | ||
| }).subscribe( | ||
| err => { | ||
| console.log(('failed to send mail')); | ||
| } | ||
| ); |
There was a problem hiding this comment.
I feel like this part should be done in one block in the 'reject_project' call (in the backend), instead of doing two separate api calls.
| } | ||
| res.end(); |
There was a problem hiding this comment.
Not need for this line, the res.send() above is sufficient
rsiminel
added a commit
to rsiminel/genouestaccountmanager
that referenced
this pull request
Jan 29, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve this issue : #554