Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QC Page with Mock Data #27

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add QC Page with Mock Data #27

wants to merge 8 commits into from

Conversation

moedarrah
Copy link
Collaborator

@moedarrah moedarrah commented Sep 25, 2024 •
edited
Loading

Screenshot 2024-09-26 at 08 39 26

@moedarrah moedarrah requested a review from a team as a code owner September 25, 2024 12:46
@moedarrah moedarrah marked this pull request as draft September 25, 2024 14:12
@moedarrah moedarrah marked this pull request as ready for review October 1, 2024 07:49
@sylvinite sylvinite self-assigned this Oct 14, 2024
sylvinite
sylvinite approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@sylvinite sylvinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good! Impressive!
Some issues I see:

  • There is no indicator of which row concerns which run/sample
  • Sample-to-sample comparisons will be quite rare. If space is a concern, focus on presenting individual samples' info
  • Its good to distinguish between using the mock data in the database, and mock data created locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvinite sylvinite sylvinite approved these changes

Assignees

@sylvinite sylvinite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moedarrah @sylvinite