Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased max delay #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Increased max delay #125

wants to merge 4 commits into from

Conversation

neworderofjamie
Copy link
Contributor

@neworderofjamie neworderofjamie commented Dec 5, 2024

Heterogeneous delays were previously always stored in uint8_t, limiting them to a maximum of 255 timesteps. @mbalazs98 code this is based on always switched to uint16_t which is wasteful.

This PR implements automatic switching to uint16_t if maximum delay is >= 256

Fixes #113

@neworderofjamie neworderofjamie added enhancement New feature or request EventProp labels Dec 5, 2024
@neworderofjamie neworderofjamie added this to the mlGeNN 2.3 milestone Dec 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 63.62%. Comparing base (493d598) to head (e8b318e).

Files with missing lines Patch % Lines
ml_genn/ml_genn/compilers/compiler.py 21.05% 15 Missing ⚠️
ml_genn/ml_genn/compilers/event_prop_compiler.py 48.00% 13 Missing ⚠️
ml_genn/ml_genn/compilers/weight_update_models.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   63.70%   63.62%   -0.09%     
==========================================
  Files         102      102              
  Lines        4348     4360      +12     
==========================================
+ Hits         2770     2774       +4     
- Misses       1578     1586       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neworderofjamie neworderofjamie marked this pull request as ready for review December 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EventProp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer static delays
3 participants