Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel learning #106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Kernel learning #106

wants to merge 5 commits into from

Conversation

neworderofjamie
Copy link
Contributor

Using the temporary functionality for modifying KERNEL_G variables implemented in genn-team/genn#631, this re-instates learning of convolutions with EventProp

@neworderofjamie neworderofjamie requested a review from tnowotny July 15, 2024 09:59
@neworderofjamie neworderofjamie added enhancement New feature or request EventProp labels Jul 15, 2024
@neworderofjamie neworderofjamie added this to the mlGeNN 2.3 milestone Jul 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.64%. Comparing base (1ff0c7f) to head (62aa216).

Files with missing lines Patch % Lines
ml_genn/ml_genn/compilers/event_prop_compiler.py 6.25% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   64.80%   64.64%   -0.16%     
==========================================
  Files         101      101              
  Lines        4259     4271      +12     
==========================================
+ Hits         2760     2761       +1     
- Misses       1499     1510      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks surprisingly simple. I assume you have run some sort of test.

@neworderofjamie neworderofjamie modified the milestones: mlGeNN 2.3, mlGeNN 2.X Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EventProp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants