feat: Reroute assets to /examples #20
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary comments regarding basePath issues.
i14h
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
@huangjeff5 have you tested this in app hosting? looks good to me, but lets test it out in app hosting, then setup a 301 for examples.genkit.dev, then deploy to production
|
What is the rollout plan for this so that it isn't in a broken state while we transition? I might recommend setting up a new App Hosting backend for this branch and keeping the old branch live until we're ready to implement the redirects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support re-routing to genkit.dev/examples. All the assets and API endpoints need to hit
/examplesas the base path instead of/.Ran into issues with the NextJS image optimization after setting basePath that I couldn't figure out, so using a custom image loader instead.