Read account names #161
Closed
Read account names #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
requested changes
Nov 14, 2024
src/DTO/NamedAccount.php
Outdated
|
|
||
| use Genkgo\Camt\Iban; | ||
|
|
||
| class NamedAccount extends Account |
There was a problem hiding this comment.
We should not introduce a new class here. The spec defines Acc as type CashAccount25. And CashAccount25 defines an object that has must have an ID (IBAN or Othr), and may have a name. Thus the name property must be added on the existing IbanAccount
|
@PowerKiKi I've done those things |
|
Sorry for the late review. I re-worked your work into #166 and released as 2.9.0. This excludes the recent commit that modify the specification, as it should probably not live in this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.