Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Graphics class and every related class, struct and enum #20

Merged
merged 220 commits into from
Jan 9, 2025
Merged

Support for Graphics class and every related class, struct and enum #20

merged 220 commits into from
Jan 9, 2025

Conversation

damiansalvia
Copy link
Collaborator

The main classes and structures included in this PR are:

  • Graphics
  • Brush (and subclasses SolidBrush, TextureBrush, HatchBrush, LinearGradientBrush and PathGradientBrush)
  • Pen
  • Region
  • StringFormat
  • GraphicsPath
  • Matrix

Also includes:

  • Simple test cases for each new class and struct, whose expected values derived from the System.Drawing library
  • An update for the README file including all these new classes, structs and enums
  • Several fixes and implementation of missing features for classes and structs already defined

With this implemenattion, the GeneXus.Drawing library is now fully complete according to our scope.

damiansalvia added 30 commits July 17, 2024 15:32
add Matrix class
f95d003
add StringFormat class and referenced enum/classes
8ea181b
add GraphicsPath and its dependencies (except for Pen, Brush and Grap…
a33518b 
…hics classes)
add Brush class
d585997
add SolidBrush class
4669b61
add Brushes class
f02453e
add TextureBrush class and WrapMode enum
9944486
add HatchBrush style and HatchStyle enum
9f6c0e9
add LinearGradientBrush class and referenced enum/classes
c7b826f
add PathGradientBrush class
693b07a
add Pen class and referenced enums
457314d
add GraphicsPath class methods' implementation depending on Pen and B…
3c43ad0 
…rush
add Region class and RegionDataClass class, update RectangleF with re…
0e10e8e 
…quired methods/properties
add Graphics and referenced enum/class, update references from other …
0b96006 
…classes
fix indentation spaces by tabs
78d2357
fix Region.GetBounds signature and fix error when Graphics parameter …
f2a2852 
…is null
fix methods depending on Graphics class (TODOs)
ccf6283
add Region class test-cases
b5d07bf
fix Region.IsVisible method considering Graphics parameter
a48994a
minor: remove unrequired usings in tests
b8978e4
define PathPointType as byte
f18809d
fix infinite recursion
fe6666f
define helper methods as private
e7b43ad
fix IsVisible and IsOutlineVisible helper methods
ad8f362
fix GetBound method
2e3ed4d
fix PathType property and CreatePath helper method
8ba0726
minor fix
f77c4a9
fix AddBezier helper method
8e9ac8f
fix AddLine helper method
6b1acb4
fix AddPie helper method
4d5bfef
damiansalvia added 22 commits September 12, 2024 23:11
fix Gracphis.IsVisible disposable reference by making a copy
1cf5bd3
consider font Unit in Graphics' DrawString, MeasureCharacterRanges an…
d1ccf87 
…d MeasureStringInternal methods
fix lineHeight calculation in GraphicsPath.AddString method
96c7545
add ColorTranslator class
970c794
fix Color class for known colors by setting the name and index
4fe30e9
minor fix in description of ColorTranslator class
e8a9c9e
add ConvertFromString method in ColorTranslator class
a1da166
add ColorConverter class
8324182
update ColorTranslator unit test after fixing known colors for Color …
d742aa3 
…class
add summary for ColorConverter class and update README
e4b1b38
fix AddString typeface disposed variable
b54e031
minor change
e8649b7
add note for Graphics.DrawString method that uses path drawing instea…
7238c05 
…d of skia's DrawText method; as a result, the output may experience a slight offset in positioning and measuring
add Graphics.GetStringBounds private method to be used by MeasureChar…
e76ef8b 
…acterRanges and MeasureStringInternal public methods
add ceiling in GraphicsPath.AddString method in order to skia can ren…
9558d90 
…der the underline when the rectangle is defined by floating values
minor change in StringFormat.ApplyWrapping and StringFormat.ApplyTrim…
66dbf9e 
…ming method when deciding split text in a new line
add CompareImage to Utils class for comparing images
6640856
add notes in Graphics class for PixelOffsetMode, TextContrast and Tex…
ac9bbfc 
…tRenderingHint properties
add unit tests for Graphics class
9904c00
Merge https://github.com/genexuslabs/GeneXus.Drawing-DotNet into feat…
d59937b 
…ure/graphics
add SolidBrush to README
6c89811
add StringFormat to README
e680b2c
claudiamurialdo
claudiamurialdo approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@claudiamurialdo claudiamurialdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damiansalvia damiansalvia merged commit ddc9411 into main Jan 9, 2025
3 checks passed
@damiansalvia damiansalvia deleted the feature/graphics branch January 9, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiamurialdo claudiamurialdo claudiamurialdo approved these changes

@fedeazzato fedeazzato Awaiting requested review from fedeazzato

@cinthamo cinthamo Awaiting requested review from cinthamo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damiansalvia @claudiamurialdo