fix: minor updates to answer relevance #245
Merged
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Reiss <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
frreiss
changed the title
jakelorocco
approved these changes
Dec 3, 2025
Contributor
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
LGTM; I pushed a commit removing the exception raising but added a warning message about using model options and intrinsics
will merge once the checks run again
jakelorocco
force-pushed
the
intrinsics2
branch
from
3815b4c to
b2aff1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a typo in the answer relevance intrinsic's wrapper function and adds some code to apply the
temperatureparameter when generating with an intrinsic.