Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prometheus-client from 2.1.0 to 4.0.0 #189

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 28, 2022

Bumps prometheus-client from 2.1.0 to 4.0.0.

Release notes

Sourced from prometheus-client's releases.

v4.0.0 / 2022-03-27

Codename: The "barely a release" release

This version contains a single - sadly breaking - change.

  • #251 Remove framework-specific route detection from collector middleware: In 3.0.0 we shipped a feature that attempted to use framework-specific information to determine the path of the request in Prometheus::Middleware::Collector.

    Sadly, we found out after shipping it that it was prone to multiple issues. We spent a decent amount of time looking into them in depth, and came to the conclusion that there wasn't any reasonable way to fix them - the issues are inherent to the feature.

    For a full, detailed write-up of our investigation, see this comment.

    Almost all users will be unaffected by this change, but it is breaking per the definition we've used for previous releases, so we've erred on the side of caution and bumped the major version to communicate that.

    If you use Sinatra or Grape with the Prometheus::Middleware::Collector, you will notice different path labels being generated. If not, this release will change nothing for you.

    If you want the behaviour from 3.0.0 - or any custom path label generation you'd prefer - we've updated our collector middleware documentation.

    This may be a breaking change. Labels may change in existing metrics.

v3.0.0 / 2022-02-05

This new major version includes some breaking changes. They should be reasonably easy to adapt to, but please read the details below:

Breaking changes

Please refer to https://github.com/prometheus/client_ruby/blob/HEAD/UPGRADING.md for details on upgrading from versions < 3.0.0.

  • #206 Include SCRIPT_NAME when determining path in Collector: When determining the path for a request, Rack::Request prefixes the SCRIPT_NAME. This was a problem with our code when using mountable engines, where the engine part of the path gets lost. This patch fixes that to include SCRIPT_NAME as part of the path.

    This may be a breaking change. Labels may change in existing metrics.

  • #245 Use framework-specific route

... (truncated)

Changelog

Sourced from prometheus-client's changelog.

4.0.0 / 2022-03-27

Codename: The "barely a release" release

This version contains a single - sadly breaking - change.

  • #251 Remove framework-specific route detection from collector middleware: In 3.0.0 we shipped a feature that attempted to use framework-specific information to determine the path of the request in Prometheus::Middleware::Collector.

    Sadly, we found out after shipping it that it was prone to multiple issues. We spent a decent amount of time looking into them in depth, and came to the conclusion that there wasn't any reasonable way to fix them - the issues are inherent to the feature.

    For a full, detailed write-up of our investigation, see this comment.

    Almost all users will be unaffected by this change, but it is breaking per the definition we've used for previous releases, so we've erred on the side of caution and bumped the major version to communicate that.

    If you use Sinatra or Grape with the Prometheus::Middleware::Collector, you will notice different path labels being generated. If not, this release will change nothing for you.

    If you want the behaviour from 3.0.0 - or any custom path label generation you'd prefer - we've updated our collector middleware documentation.

    This may be a breaking change. Labels may change in existing metrics.

3.0.0 / 2022-02-05

This new major version includes some breaking changes. They should be reasonably easy to adapt to, but please read the details below:

Breaking changes

Please refer to https://github.com/prometheus/client_ruby/blob/master/UPGRADING.md for details on upgrading from versions < 3.0.0.

  • #206 Include SCRIPT_NAME when determining path in Collector: When determining the path for a request, Rack::Request prefixes the SCRIPT_NAME. This was a problem with our code when using mountable engines, where the engine part of the path gets lost. This patch fixes that to include SCRIPT_NAME as part of the path.

    This may be a breaking change. Labels may change in existing metrics.

... (truncated)

Commits
  • 8740786 Merge pull request #252 from prometheus/sinjo-prepare-4-0
  • 05823a8 Add instructions for 4.0.0 to UPGRADING.md
  • 0736ca1 Update CHANGELOG.md for 4.0.0
  • 62dcd1a Bump version to 4.0.0
  • e2afbe7 Merge pull request #251 from prometheus/sinjo-remove-framework-specific-routing
  • 1dfc1ad Document how to override path label generation in collector
  • e0dd0f9 Remove framework-specific route detection from collector middleware
  • 134c1fd Merge pull request #248 from prometheus/sinjo-fix-gemspec-licence
  • ad9133f Fix license name in gemspec
  • 82d41f1 Merge pull request #246 from prometheus/sinjo-update-readme-date
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Mar 28, 2022
@dependabot dependabot bot force-pushed the dependabot/bundler/prometheus-client-4.0.0 branch 2 times, most recently from 0db5497 to a76b778 Compare September 16, 2022 20:25
@dependabot dependabot bot force-pushed the dependabot/bundler/prometheus-client-4.0.0 branch 2 times, most recently from 5330ec5 to 752592c Compare November 8, 2022 04:19
@dependabot dependabot bot force-pushed the dependabot/bundler/prometheus-client-4.0.0 branch 3 times, most recently from 81e5c29 to 4fee0b1 Compare January 26, 2023 12:39
Bumps [prometheus-client](https://github.com/prometheus/client_ruby) from 2.1.0 to 4.0.0.
- [Release notes](https://github.com/prometheus/client_ruby/releases)
- [Changelog](https://github.com/prometheus/client_ruby/blob/master/CHANGELOG.md)
- [Commits](prometheus/client_ruby@v2.1.0...v4.0.0)

---
updated-dependencies:
- dependency-name: prometheus-client
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/prometheus-client-4.0.0 branch from 4fee0b1 to 0fe948f Compare January 26, 2023 12:53
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 21, 2023

Superseded by #301.

@dependabot dependabot bot closed this Mar 21, 2023
@dependabot dependabot bot deleted the dependabot/bundler/prometheus-client-4.0.0 branch March 21, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants