Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support and labels for UI Internationalization and Localization #83

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

carloshm
Copy link

@carloshm carloshm commented Apr 17, 2021

Initial pull request with:

  • addition of labels for different languages (added new ui_lang parameter in config as lang from DarkSky does not support all potential languages to be included)
  • instead of using localtime, added Babel to include localization in dates (potential additional review for other not included)
  • Fix text positioning to include multi-language labels

TODO

  • add changes to webconfig project to be able to edit language in ui_lang
  • review all dates for intl
  • review ltr, rtl scenarios
  • add more languages resource files
  • review potential actions to wrap text

@genebean I considered adding this as a minor version and fix for positioning

@carloshm carloshm closed this Apr 17, 2021
@carloshm carloshm reopened this Apr 17, 2021
@genebean
Copy link
Owner

Hello @carloshm! Are you actively using the code from this PR? I ask because I saw some pushes this morning that brought it to my attention. Either way, I'll try and review this shortly. Sorry for the long delay... burnout kicked in and I had to walk away.

@carloshm
Copy link
Author

carloshm commented Aug 12, 2024

Yeah, I just did some changes for my local parents setup. Latest changes moved app to open-meteo and local changes. It may need some review to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants