Perp chart style updates #1455
Merged
Perp chart style updates #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the color mapping for stop loss, entry, and liquidation lines in ChartLineViewModel for better visual distinction. Unified the line style to a consistent dashed pattern. Reduced line opacity and refined label padding and corner radius in CandlestickChartView for improved chart readability.
gemdev111
changed the title
Extracted chart grid line and color styling into a new ChartGridStyle struct for reuse and consistency. Updated CandlestickChartView to use ChartGridStyle for axis grid lines and ticks.
ChartLine now includes a decimals property, allowing for more precise price formatting. ChartLineViewModel uses PerpetualFormatter to display price labels with correct decimal places. CandlestickChartView label styling and spacing have been adjusted for better appearance.
gemcoder21
approved these changes
Dec 8, 2025
Replaced PerpetualFormatter with CurrencyFormatter in ChartLineViewModel and PerpetualSceneViewModel. Removed decimals property from ChartLine struct and its usage. Updated CurrencyFormatter to trim whitespace from formatted strings and added related tests. Simplified label padding in CandlestickChartView.
Replaces the 'Liquidation' label with 'Liq' for the 'charts.liquidation' key across all supported localizations and updates the fallback value in Localized.swift. This change ensures consistency and brevity in chart terminology.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the color mapping for stop loss, entry, and liquidation lines in ChartLineViewModel for better visual distinction. Unified the line style to a consistent dashed pattern. Reduced line opacity and refined label padding and corner radius in CandlestickChartView for improved chart readability.
Added price for each line
Fixed perp details title showed with delay
Decrease opacity for a grid to highlight lines
images: