Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: resolve 445? #605

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: resolve 445? #605

wants to merge 1 commit into from

Conversation

tpolecat
Copy link
Member

The intent here is to resolve #445 but my test passes even with the constraint triggers defined, so I'm not sure what's up. Asked Carlos to comment on the original issue.

@mergify mergify bot added the service label Jul 26, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.12% 🎉

Comparison is base (885710f) 79.25% compared to head (e1d6882) 79.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   79.25%   79.38%   +0.12%     
==========================================
  Files         484      484              
  Lines        7936     7936              
  Branches       19       19              
==========================================
+ Hits         6290     6300      +10     
+ Misses       1646     1636      -10     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing observation events
2 participants