hacc: fix bug where numThreads were different in places #70
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerjg
reviewed
Mar 26, 2025
nthreads and numThreads are used in different places in HACC. However, it appears that numThreads > nthreads causes segfaults because the iq vector is accessed out of bounds. To resolve this, create a new global variable with the number of threads and use this for both numThreads and nthreads. I tested this worked with 4 threads. Sidenote: although HACC refers to these as threads, they appear to actually be GPU streams.
powerjg
approved these changes
Mar 26, 2025
|
I will update the binary and upload it to the cloud bucket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nthreads and numThreads are used in different places in HACC. However, it appears that numThreads > nthreads causes segfaults because the iq vector is accessed out of bounds. To resolve this, create a new global variable with the number of threads and use this for both numThreads and nthreads. I tested this worked with 4 threads.
Sidenote: although HACC refers to these as threads, they appear to actually be GPU streams.