This repository has been archived by the owner on May 28, 2019. It is now read-only.
IRV - When clicking on the map, show zonal information in a more structured way #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'name': nameAndType.name, | ||
| 'value': features[0].properties[field] | ||
| }; | ||
| switch (nameAndType.type) { |
There was a problem hiding this comment.
'default:' case missing, is it correct ?
There was a problem hiding this comment.
All cases should be covered, unless the project definition is wrong. I am adding a default, giving warning in such corner case, through an alert.
|
No tests on CI for this branch ? |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addressing #583
With this change, instead of just displaying the raw and unsorted data, the application searches the extended names and types of variables by scanning the project definition. Then the variables are presented in a structured way, collected by type.
Tests are green: https://ci.openquake.org/job/zdevel_oq-platform/252/